Skip to content

Commit

Permalink
fix: invalid toggleMode option in full mobile panel
Browse files Browse the repository at this point in the history
  • Loading branch information
lijinke666 committed Sep 26, 2020
1 parent 576470f commit da20e32
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
8 changes: 8 additions & 0 deletions __tests__/tests/player.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1495,4 +1495,12 @@ describe('<ReactJkMusicPlayer/>', () => {
wrapper.find('.hide-panel').simulate('click')
expect(onAudioListsPanelChange).not.toHaveBeenCalled()
})

it('should not render toggle mode close button in mobile panel', () => {
const wrapper = mount(<ReactJkMusicPlayer mode="full" toggleMode={false} />)
wrapper.setState({ isMobile: true })
expect(
wrapper.find('.react-jinke-music-player-mobile-header-right'),
).toHaveLength(0)
})
})
9 changes: 6 additions & 3 deletions src/components/PlayerMobile.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const PlayerMobile = ({
autoHiddenCover,
icon,
locale,
toggleMode,
}) => (
<div className={cls(prefix, { 'default-bg': !glassBg, 'glass-bg': glassBg })}>
<PlayModeTip
Expand All @@ -41,9 +42,11 @@ const PlayerMobile = ({
<div className={`${prefix}-header-title`} title={name}>
{name}
</div>
<div className={`${prefix}-header-right`} onClick={onClose}>
{icon.close}
</div>
{toggleMode && (
<div className={`${prefix}-header-right`} onClick={onClose}>
{icon.close}
</div>
)}
</div>
<div className={`${prefix}-singer text-center group`}>
<span className={`${prefix}-singer-name`} title={singer}>
Expand Down
1 change: 1 addition & 0 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,7 @@ export default class ReactJkMusicPlayer extends PureComponent {
autoHiddenCover={autoHiddenCover}
onCoverClick={this.onCoverClick}
locale={locale}
toggleMode={toggleMode}
/>
)}

Expand Down

0 comments on commit da20e32

Please sign in to comment.