Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot return to full screen from the mini-player when in a mobile device #163

Closed
deluan opened this issue Sep 25, 2020 · 4 comments
Closed

Comments

@deluan
Copy link

deluan commented Sep 25, 2020

Version

4.8.2, but this has been happening for a while, at least since 4.6.0

Description

When the player is full screen (in compact mode), if you change it to the mini-player you cannot get back to full screen by touching/clicking the floating mini player cover.

Reproduce Link

https://www.lijinke.cn/react-music-player/

Steps to Reproduce

  1. Using an Android device, go to the demo site
  2. Start the player (touch the "play" button)
  3. Close the player using the little "x" button on the top right. Now the player is in "mini" mode
  4. If you now touch the floating mini player, it does not go back to full screen.

Expected Behavior

When touching the mini-player, it should go back to full screen, as it happens when using Chrome in a desktop/laptop computer.

Current Behavior

Nothing happens when the floating mini-player is touched

System information

Tested with Chrome on Android 10 and 11

Comments

By the way, is there a way to use the mobile version of the full-screen player in a with larger screen, as opposed to having the player as a bar in the bottom of the screen?

@issue-label-bot issue-label-bot bot added the bug label Sep 25, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@lijinke666
Copy link
Owner

I use react-draggable to implementation drag feature for mini mode, but the lib will trigger onDrag event when touched mini mode on Android device, so cannot toggle to full screen. I improved and fixed on this issue. It works fine on my Android device. please wait for the new release

By the way, is there a way to use the mobile version of the full-screen player in a with larger screen, as opposed to having the player as a bar in the bottom of the screen?

What is the usage case? maybe for ipad ?

@deluan
Copy link
Author

deluan commented Sep 27, 2020

Thanks for taking care of this, really appreciate your efforts!

What is the usage case? maybe for ipad ?

A user of my music server is trying to use it on a Raspberry Pi 7" display: navidrome/navidrome#520. I think it would also be useful for tablets, to give the user the option to have the player in full screen or as a bar at the bottom

@lijinke666
Copy link
Owner

Sounds like a good idea, If I have time, I will implement this feature, i will open a new feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants