Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp shows 00:60 instead of 01:00 #242

Closed
JeffreyCA opened this issue Dec 29, 2020 · 3 comments
Closed

Timestamp shows 00:60 instead of 01:00 #242

JeffreyCA opened this issue Dec 29, 2020 · 3 comments

Comments

@JeffreyCA
Copy link
Contributor

Version

Latest

Description

The timestamp goes from 00:59 to 00:60 to 01:01.

Steps

  1. Go to demo site: https://www.lijinke.cn/react-music-player/
  2. Play track from around 00:55
  3. Observe the left timestamp

Expected Behavior

The timestamp goes from 00:59 to 01:00 to 01:01.

Current Behavior

The timestamp goes from 00:59 to 00:60 to 01:01.

System information

macOS 11.1

Video

Bug.mov
@JeffreyCA
Copy link
Contributor Author

I think it can be fixed by changing s > 60 to s >= 60 here:

if (s > 60) {
i = parseInt(s / 60)
s = parseInt(s % 60)
if (i > 60) {
h = parseInt(i / 60)
i = parseInt(i % 60)
}
}

lijinke666 added a commit that referenced this issue Jan 5, 2021
@lijinke666
Copy link
Owner

Fixed. thanks

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Hello @JeffreyCA, This bug has been fixed and will be released together with the next release.
你好 @JeffreyCA,这个bug已经修复, 会在下个版本一起发布。

@github-actions github-actions bot closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants