Add final scale value to onPinchEnd callback #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I have ImageZoom elements within an existing carousel, and I need to disable the carousel's gesture handlers when the image is zoomed in. There does not seem to be an easy way, currently, to get the current scale for the image. With the existing callback, if you use
event.scale
, it may return a value less than 1 because it returns the result of the gesture and not what the clamped value is.My guess at a fix (testing locally, I have another branch locally anyway to use Expo Image) is to add the scale as an argument to the
onPinchEnd
callback with the actual rendered scale.(Also v3 could not have come at a better time, love it)