-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Db aliases #11
Closed
Closed
Db aliases #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: source/actions/index.js source/jobs/executors.js source/jobs/resolvers.js source/triggers/index.js
Conflicts: source/jobs/executors.js
Actually, disregard this PR; it contains way too many changes, like support for I need to make these more organized and clear before commiting a PR |
Thx @gvilarino I will wait for smaller one :) |
It's now available on #12 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easy to integrate
notifier
with DBs with different schema names than the ones expected bynotifier
.For instance, if instead of having your app users under a mongo collection named
user
you would have a hard time integratingnotifier
into it.You can now specify aliases for collection names easily in your config files:
That would make all calls to
db.user
actually use theplayers
colleciton in your DB.The only change needed by this PR is that
config
files now have thisdb
element and havingconnection
inside of it. But the sample file modifications are also included here.P.S.: I know there are a lot of changes in the PR but that's because I forked before the 0.1.0 release. It shouldn't affect anything.