Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃 Prevent 0 gas #237

Merged
merged 2 commits into from
Feb 8, 2021
Merged

馃 Prevent 0 gas #237

merged 2 commits into from
Feb 8, 2021

Conversation

nwingt
Copy link
Member

@nwingt nwingt commented Dec 9, 2020

No description provided.

@williamchong
Copy link
Member

Should we add some console.warn and collect some statistics via sentry to see how often it happens?

@nwingt
Copy link
Member Author

nwingt commented Dec 9, 2020

It is already captured by Sentry in L159

@williamchong
Copy link
Member

I mean logs for how often estimatedGas === 0 happens, sorry for confusion
Does L159 catch this case?

williamchong
williamchong requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@williamchong williamchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is logMessage used?

@nwingt
Copy link
Member Author

nwingt commented Dec 10, 2020

Force-pushed

@nwingt nwingt merged commit b6e2bd7 into likecoin:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamchong williamchong williamchong approved these changes

@nnkken nnkken Awaiting requested review from nnkken

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nwingt @williamchong @nnkken