Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp to likecoin-js #22

Merged
merged 23 commits into from
Nov 29, 2021
Merged

Revamp to likecoin-js #22

merged 23 commits into from
Nov 29, 2021

Conversation

williamchong
Copy link
Member

Add arweave, iscn and tx module
Maintain likepay qr code functionalities for this version, which we plan to remove

@williamchong williamchong force-pushed the feature/revamp branch 2 times, most recently from ca95bd4 to f2150b9 Compare November 22, 2021 20:58
@williamchong williamchong marked this pull request as ready for review November 22, 2021 20:58
README.md Outdated

## Reference
https://docs.like.co/developer/like-pay/sdk/reference
Please refer to `exmaple` for usage examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please refer to `exmaple` for usage examples
Please refer to `example` for usage examples

src/types.ts Outdated
list?: ArweavePriceWithLIKE[];
}

export type estimateArweaveResponse = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export type estimateArweaveResponse = {
export type EstimateArweaveResponse = {

src/types.ts Outdated
address: string;
}

export type uploadArweaveResponse = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export type uploadArweaveResponse = {
export type UploadArweaveResponse = {

@williamchong williamchong merged commit 38d6bad into master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants