Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAS-365] ✨ Add trending NFT in index page #1326

Merged
merged 7 commits into from
Sep 14, 2023

Conversation

nwingt
Copy link
Member

@nwingt nwingt commented Sep 12, 2023

Desktop

image image

Mobile

image

@notion-workspace
Copy link

nwingt added a commit that referenced this pull request Sep 12, 2023
src/constant/index.js Outdated Show resolved Hide resolved
@show.once="fetchTrendingNFTList"
/>
</client-only>
<IndexPageTrendingNFTList
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we lazy load this component all together? swiper is resource heavy and below the fold

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

nwingt added a commit that referenced this pull request Sep 13, 2023
@nwingt
Copy link
Member Author

nwingt commented Sep 13, 2023

Tested, ready for code review

@williamchong williamchong merged commit 93edeef into likecoin:develop Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants