[TAS-458] ✨ Add more NFT Books page #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nwingt
commented
Sep 26, 2023
•
nwingt
commented
nwingt
added a commit
that referenced
this pull request
Sep 26, 2023
nwingt
added a commit
that referenced
this pull request
Sep 26, 2023
src/mixins/nft.js
Outdated
| @@ -184,6 +184,9 @@ export default { | |||
| this.NFTClassMetadata.account_owner | |||
| ); | |||
| }, | |||
| iscnAuthor() { | |||
There was a problem hiding this comment.
this name might cause potential confusion in the future but i have no good suggestion...
iscnMetadataAuthor ?
There was a problem hiding this comment.
How about iscnWorkAuthor that imply Author under CreativeWork in schema.org
src/components/NFTBook/ItemCard.vue
Outdated
| @@ -44,7 +44,7 @@ | |||
| <Label | |||
| class="text-medium-gray mt-[6px] mb-[12px]" | |||
| preset="p6" | |||
| :text="creatorDisplayName | ellipsis" | |||
| :text="(iscnAuthor || creatorDisplayName) | ellipsis" | |||
There was a problem hiding this comment.
I think it can be a computed property
There was a problem hiding this comment.
can change to computed property if we used it more than once
WeiJun0827
added a commit
that referenced
this pull request
Sep 28, 2023
nwingt
added a commit
that referenced
this pull request
Sep 29, 2023
nwingt
force-pushed
the
feature/book-page
branch
from
540ca3e
to
a379eca
Compare
nwingt
added a commit
that referenced
this pull request
Sep 29, 2023
williamchong
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.