Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project init with nuxt and vuetifyjs #24

Merged
merged 17 commits into from
Jun 6, 2018

Conversation

rickmak
Copy link
Collaborator

@rickmak rickmak commented Jun 5, 2018

The project init is docker base and should be easy to kick start by following
the README.

connect #5

package.json Outdated
"sequelize": "^4.37.10",
"sequelize-cli": "^4.0.0",
"source-map-support": "^0.4.15"
"source-map-support": "^0.4.15",
"vue": "^2.5.16",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want to list vue-server-renderer and vue-template-compiler too if listing vue as dep,
since all 3 need to be sync in version

Another way is just use // eslint-disable-line import/no-extraneous-dependencies when import Vue from 'vue'; in plugins,
since nuxt must have Vue anyway

Copy link
Member

@nwingt nwingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove those <img /> elements

@@ -0,0 +1,37 @@
<template>
<section class="container">
<img src="../assets/img/logo.png" alt="Nuxt.js Logo" class="logo" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

../assets/img/logo.png is missing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not missing on my setting. The file is checking here: https://github.com/rickmak/puttyimages-web/blob/0d6ee56c849ddbe65795099d5abbea773f8359b0/assets/img/logo.png

Just to confirm the path resolve setting is right. I will remove the dummy img.

pages/_id.vue Outdated
@@ -0,0 +1,45 @@
<template>
<section class="container">
<img src="~assets/img/logo.png" alt="Nuxt.js Logo" class="logo" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~/assets/img/logo.png is missing

pages/index.vue Outdated
@@ -0,0 +1,38 @@
<template>
<section class="container">
<img src="~assets/img/logo.png" alt="Nuxt.js Logo" class="logo" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~/assets/img/logo.png is missing

@rickmak
Copy link
Collaborator Author

rickmak commented Jun 5, 2018

Updated according to comments.

@rickmak
Copy link
Collaborator Author

rickmak commented Jun 6, 2018

With @williamchong007 and @nwingt approval, I will merge this into likeCoin master if no other comments in coming 6 hours.

@williamchong williamchong merged commit 7a12a4d into likecoin:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants