-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃攢 Add continuous integration pipeline #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pipeline is with Travis, Docker Hub and pandawork cluster. refs likecoin#23
This is to avoid deadlock on the Travis cannot trigger deployment before Travis is return a success status.
williamchong
reviewed
Jun 8, 2018
extends: [ | ||
'airbnb-base', | ||
'plugin:jest/recommended', | ||
'prettier', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just found out about plugin:vue/essential
, maybe want to add it also
https://www.npmjs.com/package/eslint-plugin-vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let follow up on #34
nwingt
approved these changes
Jun 8, 2018
- The continuous deployment setup is against with oursky/puttimages-web to https://puttyimages.pandawork.com - It comes with example unit and integration test - Test are run at Travis-CI - It includes seeding data for kick start dev and test refs #5
mileswong
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please checkout https://puttyimages.pandawork.com
connects #5