🔀 Add search API #53
Merged
🔀 Add search API #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inDream
force-pushed
the
add-search
branch
2 times, most recently
from
2056e83
to
47f717d
Compare
rickmak
requested changes
Jun 20, 2018
server/api/search.js
Outdated
| query, | ||
| } = req; | ||
| let offset = 0; | ||
| let q = decodeURIComponent(query.q || ''); |
There was a problem hiding this comment.
I suggest the whole pagination logic to in an separate testable module in stead of putting inline here in the controller.
i.e. in server/utils/index:getPageInfo and the parseQuery here belong to server/utils/paginator and create Paginate class and PageInfo class to represent the logic here.
server/api/search.js
Outdated
| }; | ||
| } | ||
|
|
||
| const { count, rows } = await sequelize.asset.findAndCountAll({ |
There was a problem hiding this comment.
Put the SQL building model.asset?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects #2
Due to database schema changes, seed data need to reset.
Command:
npm run sequelize:reseed