Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise exception if only one count matrix exists #106

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

yihming
Copy link
Member

@yihming yihming commented Jul 13, 2023

This is for backward compatibility.

Although the default name of raw count matrix has been changed from raw.count or X to counts, we still want to make the data generated by old versions of PegasusIO can still be loaded.

The rna modality doesn't have this issue, because it by default sets None for cur_matrix. But for other modalities, since they have default key names, it restricts the loading.

For example, Souporcell workflow uses PegasusIO v0.2.10, which is the last version supporting Python 3.6, to generate results.

@yihming yihming merged commit 799a461 into master Jul 13, 2023
3 checks passed
@yihming yihming deleted the bug-fix branch July 13, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant