Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnimodalDataView.copy() returns MultimodalData by default #111

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

yihming
Copy link
Member

@yihming yihming commented Jan 20, 2024

Fix 1

The copy() function of UnimodalDataView now returns a MultimodalData object by default (previously UnimodalData), with an option to_unidata if users still want a UnimodalData object.

Fix 2

pd.concat emits the following warning:

The behavior of DataFrame concatenation with empty or all-NA entries is deprecated. In a future version, this will no longer exclude empty or all-NA columns when determining the result dtypes. To retain the old behavior, exclude the relevant entries before the concat operation

when it concatenates at least one empty DataFrame. So add an justifier and explicitly set None for empty DataFrame objects.

@yihming yihming requested review from bli25 and removed request for bli25 January 20, 2024 02:59
@yihming yihming merged commit b47b764 into master Jan 20, 2024
4 checks passed
@yihming yihming deleted the modify-copy branch January 20, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant