Remove __lilac__ prefix for signals. #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
changed the title
nsthorat
requested review from
dsmilkov and
HalfdanJ
and removed request for
dsmilkov
HalfdanJ
reviewed
May 11, 2023
src/webClientLib/lilac.spec.ts
Outdated
| propertyA: lilacItem('valueA', { | ||
| propertyA: { | ||
| text_statistics: { | ||
| num_characters: 100 |
| */ | ||
| export function isSignalField(field: LilacSchemaField): boolean { | ||
| return field.path[0] === LILAC_COLUMN; | ||
| export function isSignalField( |
There was a problem hiding this comment.
Added a comment in your optimization bug that we can instead store parent reference in the field, and avoid extra parameter. But we can do that in seperate pr
There was a problem hiding this comment.
I think we should probably just walk downwards to 1) keep parity with python side and 2) keep json-serializability of this (since there's a circular reference), important for console.log() from unit tests
HalfdanJ
approved these changes
May 11, 2023
|
Spoke with Daniel offline, he said LGTM as he's on phone. Submitting! |
dsmilkov
reviewed
May 11, 2023
| if len(field_keys) != 2: | ||
| raise ValueError('Expected exactly two fields in signal manifest, ' | ||
| f'the row UUID and root this signal is enriching. Got {field_keys}.') | ||
| return next(filter(lambda field: field != UUID_COLUMN, manifest.data_schema.fields.keys())) |
There was a problem hiding this comment.
might be cleaner to just use manifest.enriched_path[0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything back to working:
Fixes #149