Improve dataset load onboarding flow. #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Oct 12, 2023
lilac/data/dataset.py
Outdated
| @@ -55,6 +55,8 @@ | |||
| SAMPLE_AVG_TEXT_LENGTH = 1000 | |||
| MAX_TEXT_LEN_DISTINCT_COUNT = 250 | |||
|
|
|||
| DEFAULT_EMBEDDING = 'gte-small' | |||
There was a problem hiding this comment.
should we do EMBEDDING_SORT_PRIORITIES[0] ?
lilac/data/dataset_config_test.py
Outdated
| @@ -95,7 +95,8 @@ def test_config_compute_signal(make_test_data: TestDataMaker) -> None: | |||
| name='test_dataset', | |||
| source=TestSource(), | |||
| # 'text' is the longest path, so should be set as the default setting. | |||
| settings=DatasetSettings(ui=DatasetUISettings(media_paths=[('text',)]))) | |||
| settings=DatasetSettings( | |||
| ui=DatasetUISettings(media_paths=[('text',)]), preferred_embedding=DEFAULT_EMBEDDING)) | |||
There was a problem hiding this comment.
instead of having to define it explicitly, should we default it to DEFAULT_EMB in the basemodel definition of DatasetUISetting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a dataset, show the field selection settings, improve the wording around it. Add a preview at the bottom.
Remove the datasetStore entirely. This is useless, and causes issues when using components from outside dataset pages.
dataset_onboard.mp4
https://huggingface.co/spaces/lilacai/nikhil_staging