Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider keyword version of the spread operator #19

Closed
darwin opened this issue Feb 1, 2020 · 4 comments
Closed

Consider keyword version of the spread operator #19

darwin opened this issue Feb 1, 2020 · 4 comments

Comments

@darwin
Copy link
Contributor

darwin commented Feb 1, 2020

& is a special symbol acting as a spread operator in $ macro expansion.

($ :div {:prop "val" & rest-props} ...)

This causes minor issue in Cursive which sees a normal map and complains about unresolved symbol &. I think adding support for :& to be optionally used in place of & should not hurt anynone.

($ :div {:prop "val" :& rest-props} ...)

See darwin@be5c3dc

darwin added a commit to binaryage/cljs-react-three-fiber that referenced this issue Feb 1, 2020
@lilactown
Copy link
Owner

I'd like to have it one or another, rather than have people open up a codebase and figure out if they should use & or :& or be inconsistent (probably based on what editor the author uses).

@darwin
Copy link
Contributor Author

darwin commented Feb 3, 2020

Ok, don't worry. You may close this. I will probably keep a fork of helix with some custom patches on top, so it is not a big issue for me atm.

@lilactown
Copy link
Owner

I'll keep this open as I think I want to move to a keyword version to not mess with Cursive users.

@khmelevskii
Copy link

Yes, it would be great to use :& instead of & because currently I have joker warning for this symbol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants