-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$ error when used with native components #61
Comments
Ok, I just figured that on native components we can't send This leads to a confusing situation in React Native, because some of the components there are native (string-based) and others are not (for example, Maybe Helix could always accept the |
Another option could be some validation at dev mode to let the user know that it was supposed to use a clojure or a js map in each case. |
it can maybe check |
As it stands I end up having to do |
Thanks for reporting. @tekacs your use case is very motivating. I'll release 0.0.12 with a fix soon! |
Fix #61: allow JS objects in `:style` prop for "native" components
Hello,
I found a bug in the
$
with native components.Reproduce example:
This gets an error of
Error: [object Object] is not ISeqable
I did a little dig, the problem seems to be in this line here: https://github.com/Lokeh/helix/blob/37aca5e65704da96915a4435e6825da4e4de3af7/src/helix/impl/props.cljc#L57
At my example, this ends up calling
seq
with a JS object, which triggers the error.The text was updated successfully, but these errors were encountered: