Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Ruby 2.6.3 and update & vendor gems #2

Merged
merged 7 commits into from
Oct 12, 2019
Merged

Target Ruby 2.6.3 and update & vendor gems #2

merged 7 commits into from
Oct 12, 2019

Conversation

lildude
Copy link
Owner

@lildude lildude commented Oct 12, 2019

General good practises update:

  1. Target Ruby 2.6.3 as it is now the latest
  2. Update all gems
  3. Vendor all gems
  4. Fix tests
  5. Update style to match newer rubocop rules.

As an added bonus, we now get 100% coverage too.

@lildude
Copy link
Owner Author

lildude commented Oct 12, 2019

🤔 looks like the coveralls gem was downgraded.

@lildude lildude merged commit faf30c9 into master Oct 12, 2019
@lildude lildude deleted the vendor-gems branch October 12, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant