Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when call format() with only mandatory argument (amount) #11

Merged
merged 1 commit into from Jun 27, 2017
Merged

fix bug when call format() with only mandatory argument (amount) #11

merged 1 commit into from Jun 27, 2017

Conversation

tufahu
Copy link
Contributor

@tufahu tufahu commented Jun 27, 2017

at layered navigation magento calls priceCurrency->format() with only amount argument

$formattedFromPrice = $this->priceCurrency->format($fromPrice);

at this state func_get_args get $args as an array with only one element so the plugin cannot set $args[2],

I've fixed the bug with setting includeContainer to default value when no explicit set.

@lillik lillik merged commit 0afc129 into lillik:master Jun 27, 2017
@tufahu tufahu deleted the fix-format-default-args branch June 27, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants