Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing timeout's default context to .nowOr(.auto) #50

Closed
lilyball opened this issue May 20, 2020 · 0 comments
Closed

Consider changing timeout's default context to .nowOr(.auto) #50

lilyball opened this issue May 20, 2020 · 0 comments
Labels
bug Something isn't working
Milestone
v1.2.0

Comments

@lilyball
Copy link
Owner

The default context for timeout is .auto. The downside here is if the upstream promise has already resolved, the timeout promise won't immediately propagate that. If we use .nowOr(.auto) that makes the timeout promise resolve immediately if the upstream promise is already resolved but otherwise changes no behavior.

See #34 for .nowOr(.auto)
@lilyball lilyball added this to the Next milestone May 20, 2020
@lilyball lilyball added the bug Something isn't working label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@lilyball