Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when(first:cancelRemaining:) won't cancel synchronously if all inputs have cancelled #51

Closed
lilyball opened this issue May 20, 2020 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@lilyball
Copy link
Owner

From reading the code it appears that when(first: [Promise(with: .cancelled)]) returns a pending promise that will be cancelled asynchronously (on the .utility queue). We should fix this so it synchronously cancels if all inputs were already cancelled. This will make it consistent because it already fulfills/rejects synchronously if any input has been fulfilled/rejected.

@lilyball lilyball added the bug Something isn't working label May 20, 2020
@lilyball lilyball added this to the Next milestone May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant