Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise.makeChild() #56

Closed
lilyball opened this issue Jul 21, 2020 · 0 comments
Closed

Add Promise.makeChild() #56

lilyball opened this issue Jul 21, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@lilyball
Copy link
Owner

When using Promise.propagatingCancellation(on:cancelRequested:) the client should always hand a child back to its caller. Right now the best way of producing a child looks like .then(on: .immediate, { _ in }) which is ugly and not necessarily obvious. We can add a .makeChild() method which produces a child that participates in automatic cancellation propagation, and then document this convenience on Promise.propagatingCancellation(on:cancelRequested:).

@lilyball lilyball added the enhancement New feature or request label Jul 21, 2020
@lilyball lilyball added this to the Next milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant