Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "boot" provisioning script mode #1094

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Conversation

pendo324
Copy link
Contributor

Allows users to customize their early boot workflow by specifying bootCmds. These commands are run by cloud-init-local.service, which runs before cloud-init.service (which only starts after the network is up), and allow users to disable services (as in the example) or run other commands early on in the boot process. More info here.

Resolves one of the proposals in #1093

examples/default.yaml Outdated Show resolved Hide resolved
@AkihiroSuda
Copy link
Member

Thanks, but please sign the commit for DCO
https://github.com/apps/dco

(run git commit -a -s --amend, and make sure that the Signed-off-by: NAME <EMAIL> line with your real name is included in the commit message)

@pendo324 pendo324 force-pushed the bootCmds branch 2 times, most recently from 8f12c26 to 85ba0b3 Compare October 12, 2022 18:59
AkihiroSuda
AkihiroSuda previously approved these changes Oct 12, 2022
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda
Copy link
Member

Could you squash commits?

examples/default.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I've tested it, and it works well.

I would like to see the misleading hash-bang line issue addressed.

I wouldn't insist on fixing the YAML indentation, but if you edit the PR anyways, then please address that as well.

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
@pendo324
Copy link
Contributor Author

Thanks for all the feedback. I just made all of the changes that were requested regarding the misleading example and the YAML formatting, and also rebased on latest master and squashed into one commit

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@jandubois
Copy link
Member

I don't know why the Cirrus CI checks have not been running; I'm going to close this PR and then re-open it, to hopefully trigger them again.

@jandubois jandubois closed this Oct 13, 2022
@jandubois jandubois reopened this Oct 13, 2022
@jandubois
Copy link
Member

Doing another cycle of Close+Reopen, as Cirrus-CI seems to be working fine in other repos right now; but still not triggering here.

@jandubois jandubois closed this Oct 14, 2022
@jandubois jandubois reopened this Oct 14, 2022
@AkihiroSuda AkihiroSuda changed the title Add "bootCmds" config option add "boot" provisioning script mode Oct 14, 2022
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants