Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the support for vde_vmnet (Deprecated since Sep 2022, in favor of socket_vmnet) #2311

Merged
merged 1 commit into from
May 1, 2024
Merged

Remove the support for vde_vmnet (Deprecated since Sep 2022, in favor of socket_vmnet) #2311

merged 1 commit into from
May 1, 2024

Conversation

AkihiroSuda
Copy link
Member

vde_vmnet has been deprecated since Lima v0.12.0 (Sep 2022), in favor of socket_vmnet:

Close #2096

@AkihiroSuda AkihiroSuda added this to the v0.22.0 milestone May 1, 2024
@AkihiroSuda AkihiroSuda requested a review from jandubois May 1, 2024 01:16
@AkihiroSuda AkihiroSuda force-pushed the remove-vde_vmnet branch 2 times, most recently from be70d3c to 7b52030 Compare May 1, 2024 05:44
@AkihiroSuda
Remove the support for vde_vmnet (Deprecated since Sep 2022)
0913c3b 
`vde_vmnet` has been deprecated since Lima v0.12.0 (Sep 2022),
in favor of `socket_vmnet`:
- PR 851

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
jandubois
jandubois approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic in pkg/networks/* should be rewritten to eliminate the daemon argument, now that there is only a single valid setting for it. Or do you expect that we will have another daemon choice again in the future?

@jandubois jandubois merged commit 05ed151 into lima-vm:master May 1, 2024
27 checks passed
@AkihiroSuda
Copy link
Member Author

The logic in pkg/networks/* should be rewritten to eliminate the daemon argument, now that there is only a single valid setting for it. Or do you expect that we will have another daemon choice again in the future?

👍 on elimination

@AkihiroSuda
Copy link
Member Author

Regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

Assignees
No one assigned
Labels
component/network/vmnet impact/changelog
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.

Remove the support for vde_vmnet (Deprecated since Sep 2022, in favor of socket_vmnet)
2 participants
@AkihiroSuda @jandubois