make nerdctl.lima completion works

[robberphex]

• switch to cobra
• make nerdctl.lima completion works
• support double dash --.(limactl shell default -- echo --help can work now)
• support auto-completion at bash\fish\zsh.
• fix nerdctl.lima completion doesn't work #233

[AkihiroSuda]

Thanks, but limactl start [TAB] no longer seems to complete file names

[robberphex]

Thanks, but limactl start [TAB] no longer seems to complete file names

I tested at my computer, it works:

$ source <(limactl completion bash)
$ limactl start <tab>
default  new
$ limactl __complete start ''
default
new
:4
Completion ended with directive: ShellCompDirectiveNoFileComp

@jandubois Could you paste the output of limactl __complete start ''?

[AkihiroSuda]

$ limactl start
default new

This should show file names in addition to instance names.

[jandubois]

@jandubois Could you paste the output of limactl __complete start ''?

alpine
:4
Completion ended with directive: ShellCompDirectiveNoFileComp

[robberphex]

@jandubois github.com/urfave/cli/v2 and github.com/spf13/cobra are not support completing with given value and file names.

So, in this PR, keep this behavior.

[AkihiroSuda]

$ limactl validate /dev/null 
Error: failed to load YAML file "/dev/null": field `images` must be set
Usage:
  limactl validate FILE.yaml [FILE.yaml, ...] [flags]

Flags:
  -h, --help   help for validate

Global Flags:
      --debug   debug mode

FATA[0000] failed to load YAML file "/dev/null": field `images` must be set 

Can we delete the CLI usage message like this?

[robberphex]

$ limactl validate /dev/null 
Error: failed to load YAML file "/dev/null": field `images` must be set
Usage:
  limactl validate FILE.yaml [FILE.yaml, ...] [flags]

Flags:
  -h, --help   help for validate

Global Flags:
      --debug   debug mode

FATA[0000] failed to load YAML file "/dev/null": field `images` must be set 

Can we delete the CLI usage message like this?

Which line to delete？

[AkihiroSuda]

Which line to delete？

All lines but the last one.

The output should be like this, as in the current master

$ limactl validate /dev/null 
FATA[0000] failed to load YAML file "/dev/null": field `images` must be set 

[robberphex]

Which line to delete？

All lines but the last one.

The output should be like this, as in the current master

$ limactl validate /dev/null 
FATA[0000] failed to load YAML file "/dev/null": field `images` must be set 

Fix this at commit 80934268.

$ limactl validate /dev/null
FATA[0000] failed to load YAML file "/dev/null": field `images` must be set

[AkihiroSuda]

Thanks

[robberphex]

@jandubois Hello, is there anything to fix in this PR?

[jandubois]

@jandubois Hello, is there anything to fix in this PR?

I don't know yet. 😄 I suspect it is good now, but I will do a review tomorrow, and hopefully approve, unless I find anything new. Sorry, I haven't been paying attention during the recent updates.

[csh0101]

why this message is to me？…… 发自我的iPhone

…

------------------ Original ------------------ From: Jan Dubois ***@***.***> Date: Thu,Sep 16,2021 2:12 PM To: lima-vm/lima ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [lima-vm/lima] make nerdctl.lima completion works (#234) @jandubois commented on this pull request. In cmd/limactl/delete.go: > } -func deleteAction(clicontext *cli.Context) error { -if clicontext.NArg() == 0 { +func deleteAction(cmd *cobra.Command, args []string) error { +if len(args) == 0 { Again, this is unreachable code due to MinimumNArgs(1) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[jandubois]

why this message is to me？……

You are watching the lima-vm/lima repository. Maybe you selected "All activity"? Or you pressed the "subscribe" button on issue #234. That's the only explanations I can come up with.

If you don't want further notifications, please unsubscribe from this issue (and change your repo notification settings, if that was the root cause). But since you've replied to the notifications, you are also subscribed to this issue now.

[csh0101]

thanks i know now……apology for my Recklessness 发自我的iPhone

…

------------------ Original ------------------ From: Jan Dubois ***@***.***> Date: Thu,Sep 16,2021 2:19 PM To: lima-vm/lima ***@***.***> Cc: 拓跋大山 ***@***.***>, Comment ***@***.***> Subject: Re: [lima-vm/lima] make nerdctl.lima completion works (#234) why this message is to me？…… You are watching the lima-vm/lima repository. Maybe you selected "All activity"? Or you pressed the "subscribe" button on issue #234. That's the only explanations I can come up with. If you don't want further notifications, please unsubscribe from this issue (and change your repo notification settings, if that was the root cause). But since you've replied to the notifications, you are also subscribed to this issue now. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[jandubois]

Addressing the shell error exit is the only remaining issue afaict, so pre-emptively approving before I go to sleep... 😸

[AkihiroSuda]

limactl start doesn't seem to work

$ limactl start
FATA[0000] accepts 1 arg(s), received 0  

[AkihiroSuda]

Could you squash commits?

[jandubois]

limactl start doesn't seem to work

I'm sorry, I think that is my fault: I asked for Args: cobra.ExactArgs(1) when it should have been Args: cobra.MaximumNArgs(1). Sorry about that! 😞

I believe this, and the squashing of commits are the only outstanding issues now.

[robberphex]

• limactl start doesn't seem to work, fixed
• squash commits, squashed

@AkihiroSuda I think it's time to merge.

[jandubois]

Thank you!