Add alpine-image template #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no point in creating the mnt.sh script if it is never called. Most of the diff is just whitespace changes because the indentation level of most of the file has been reduced. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Because the cloud images only come with `doas`. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
It uses the official Alpine cloud images instead of the alpine-lima ISO. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
|
We can just have a breaking change when we release v1.0 with VZ as default |
AkihiroSuda
approved these changes
May 25, 2024
afbjorklund
reviewed
May 25, 2024
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the official Alpine cloud images instead of the alpine-lima ISO.
Ideally this template should be called
alpineand the existing onealpine-iso, but that is going to break backwards compatibility.@lima-vm/maintainers Should we leave things as-is, or should I make a copy of
alpinetoalpine-iso, and then add amessageto thealpinetemplate that tells users to switch to using thealpine-isoname because at some time in the futurealpinemay become a symlink toalpine-image?I've only done cursory testing on this template, but it starts up fine on x86_64 and aarch64.
The PR should be reviewed while ignoring white-space changes; the first commit is just reducing indentation levels in
04-persistent-data-volume.sh.See also #2346 and #2359