Support port forwarding for privileged ports (1-1023) #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2021
jandubois
reviewed
Oct 2, 2021
jandubois
reviewed
Oct 2, 2021
AkihiroSuda
force-pushed
the
pseudoloopback
branch
from
ab070ae
to
a32310b
Compare
AkihiroSuda
force-pushed
the
pseudoloopback
branch
from
a32310b
to
11c08ca
Compare
jandubois
reviewed
Oct 7, 2021
jandubois
reviewed
Oct 7, 2021
pkg/hostagent/port_darwin.go
Outdated
| } | ||
| plf, err := newPseudoLoopbackForwarder(localPort, localUnix) | ||
| if err != nil { | ||
| _ = os.RemoveAll(localUnixDir) |
There was a problem hiding this comment.
Should this also call forwardSSH(ctx, sshConfig, port, localUnix, remote, true) to tear down the unused forward?
jandubois
reviewed
Oct 7, 2021
jandubois
reviewed
Oct 7, 2021
On macOS, listening on 127.0.0.1:80 requires root while 0.0.0.0:80 does not require root. For such ports, the hostagent launches "pseudoloopback" forwarder that listens on 0.0.0.0:80 but rejects connections from non-loopback src IP. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
pseudoloopback
branch
from
11c08ca
to
fa0c7ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, listening on 127.0.0.1:80 requires root while 0.0.0.0:80 does not require root.
For such ports, the hostagent launches "pseudoloopback" forwarder that listens on 0.0.0.0:80 but rejects connections from non-loopback src IP.
Fix #45