XHCI over EHCI for better performance as well as aarch64 support #497
Conversation
Signed-off-by: Jason W. Ehrlich <jwehrlich@outlook.com>
|
Resolves #499 |
| args = append(args, "-device", "usb-ehci") | ||
| args = append(args, "-device", "usb-kbd") | ||
| args = append(args, "-device", "usb-mouse") | ||
| args = append(args, "-device", "qemu-xhci,id=usb-bus") |
There was a problem hiding this comment.
This requires QEMU >= 2.9.
I guess this is fine, but cc-ing @jandubois FYI
qemu/qemu@72a810f
There was a problem hiding this comment.
I guess this is fine, but cc-ing @jandubois FYI
Yes, seems fine, and works for me.
But as I mentioned in #499, I cannot repro the failure on macOS on aarch64 with the default.yaml config.
And I was also wondering why we need USB devices at all? What happens if we just drop them?
There was a problem hiding this comment.
And I was also wondering why we need USB devices at all? What happens if we just drop them?
We will lose keyboard and mouse. Probably negligible for non-GUI mode though.
There was a problem hiding this comment.
Probably negligible for non-GUI mode though.
Do we have a GUI mode? I know we can get a console (with horrible performance impact), but is there a way to actually run a GUI?
On the other hand, I would hope that performance impact from emulating a USB device that is not being used is really minimal as well (really only thinking about battery impact when running on a laptop).
There was a problem hiding this comment.
By "GUI" I just meant setting .video.display = "cocoa"
There was a problem hiding this comment.
By "GUI" I just meant setting .video.display = "cocoa"
So maybe we drop the USB devices with the display: none setting. I may try that when I'm bored. 😄
Update to use a more friendly version USB that works with aarch64
Notes:
https://qemu-project.gitlab.io/qemu/system/devices/usb.html
Signed-off-by: Jason W. Ehrlich jwehrlich@outlook.com