-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --shell option to limactl shell #779
Conversation
Based on my previous comment is that the |
I don't know, the only shell where it makes a difference (that I'm aware off) is $ tcsh -c "echo foo"
foo
$ tcsh -l -c "echo foo"
Unknown option: `-l'
Usage: tcsh [ -bcdefilmnqstvVxX ] [ argument ... ].
$ echo "echo foo" | tcsh -l
foo So I'm not sure if we should bother; any modern shell should support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This allows to use a predictable shell for scripting, and also provides a way to recover an instance when the user shell has been misconfigured. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Because golang and shell quoting requirements are different. E.g. "foo$bar" really needs to be 'foo$bar' to avoid interpolation. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
This allows to use a predictable shell for scripting, and also provides a way to recover an instance when the user shell has
been misconfigured:
This is a followup to #775 (review)
I'm not happy about the repetition of the word "shell" in
limactl shell --shell /bin/sh ...
, but it still seems like the most appropriate name for the option.This part has been split off into #780
Also adds
LIMA_SHELL
support to thelima
command: