Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limactl start: support subdirectories #805

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

AkihiroSuda
Copy link
Member

e.g., limactl start template://deprecated/centos-7 creates an instance named centos-7

Fix #785

cmd/limactl/start.go Outdated Show resolved Hide resolved
cmd/limactl/start.go Outdated Show resolved Hide resolved
jandubois
jandubois previously approved these changes Apr 19, 2022
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the simplification from my first comment should be applied.

e.g., `limactl start template://deprecated/centos-7` creates an instance named `centos-7`

Fix issue 785

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda merged commit eabffb0 into lima-vm:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limactl start templates don't support subdirectories
2 participants