Use OpenSSH SFTP Server instead of github.com/pkg/sftp (when available) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
openssh-sftp-server
branch
from
1173633
to
dabf24c
Compare
AkihiroSuda
force-pushed
the
openssh-sftp-server
branch
from
dabf24c
to
6355214
Compare
jandubois
reviewed
Mar 18, 2022
AkihiroSuda
force-pushed
the
openssh-sftp-server
branch
from
6355214
to
65fdf2c
Compare
jandubois
reviewed
Apr 14, 2022
|
@AkihiroSuda Do you know any reasons to prefer homebrew sftp-server (9.0, OpenSSL 1.1.1n) over the macOS version (8.1, LibreSSL 2.7.3)? Background: Is there an argument that Rancher Desktop should bundle its own version instead of relying on the macOS version already installed? |
AkihiroSuda
force-pushed
the
openssh-sftp-server
branch
from
65fdf2c
to
2c16264
Compare
Because a newer version might be faster/safer.
No |
The OpenSSH SFTP Server Driver (`--driver=openssh-sftp-server`) is more robust and secure than the legacy builtin driver (`--driver=builtin`). No performance benefit though. The OpenSSH SFTP Server Driver is used by default when `sftp-server` binary is installed on the host. (Installed by default on macOS) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
openssh-sftp-server
branch
from
2c16264
to
8bc4620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenSSH SFTP Server Driver (
--driver=openssh-sftp-server) might be more robust and secure than the legacy builtin driver (--driver=builtin).No performance benefit though.
The OpenSSH SFTP Server Driver is used by default when
sftp-serverbinary is installed on the host.(Installed by default on macOS)