Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding treatment effect estimation class #93

Closed
wants to merge 3 commits into from
Closed

feat: adding treatment effect estimation class #93

wants to merge 3 commits into from

Conversation

MarIniOnz
Copy link
Contributor

Adding treatment effect estimation class, which takes MedRecord, outcomes and treatments and divide the patients in the MedRecord in control and treatment (True and False) categories.

@MarIniOnz MarIniOnz requested review from JabobKrauskopf and a team as code owners May 24, 2024 14:01
@MarIniOnz MarIniOnz force-pushed the 65-refactor-treatment-effect branch 5 times, most recently from e0c28d7 to a2aa379 Compare May 28, 2024 15:10
JabobKrauskopf
JabobKrauskopf requested changes May 29, 2024
View reviewed changes
Copy link
Member

@JabobKrauskopf JabobKrauskopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazeballs! Some minor changes requested. 🚀
And shouldn't the commit be called something like the pull request name?

medmodels/matching/matching.py Outdated Show resolved Hide resolved
medmodels/treatment_effect_estimation/tests/test_treatment_effect.py Show resolved Hide resolved
medmodels/treatment_effect_estimation/treatment_effect.py Outdated Show resolved Hide resolved
medmodels/treatment_effect_estimation/treatment_effect.py Outdated Show resolved Hide resolved
medmodels/treatment_effect_estimation/treatment_effect.py Outdated Show resolved Hide resolved
medmodels/treatment_effect_estimation/treatment_effect.py Outdated Show resolved Hide resolved
@MarIniOnz MarIniOnz force-pushed the 65-refactor-treatment-effect branch 3 times, most recently from cd954d3 to fde90c4 Compare May 29, 2024 10:12
JabobKrauskopf
JabobKrauskopf requested changes May 29, 2024
View reviewed changes
Copy link
Member

@JabobKrauskopf JabobKrauskopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry still some very minor adjustments 🙃

medmodels/treatment_effect_estimation/treatment_effect.py Outdated Show resolved Hide resolved
medmodels/treatment_effect_estimation/treatment_effect.py Outdated Show resolved Hide resolved
@MarIniOnz MarIniOnz force-pushed the 65-refactor-treatment-effect branch from fde90c4 to 9eb78c9 Compare May 29, 2024 10:34
JabobKrauskopf
JabobKrauskopf previously approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@JabobKrauskopf JabobKrauskopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazingsauce with Amazeballs 🍝

@MarIniOnz MarIniOnz linked an issue May 30, 2024 that may be closed by this pull request
Refactor Treatment Effect #65
Closed
@MarIniOnz MarIniOnz force-pushed the 65-refactor-treatment-effect branch 2 times, most recently from 7ffb679 to 585e17c Compare May 30, 2024 14:03
@MarIniOnz MarIniOnz marked this pull request as draft June 4, 2024 13:22
@MarIniOnz MarIniOnz force-pushed the 65-refactor-treatment-effect branch 6 times, most recently from ca958c6 to 585e17c Compare June 11, 2024 11:13
@MarIniOnz MarIniOnz force-pushed the 65-refactor-treatment-effect branch 3 times, most recently from a8ad19f to 3b5948d Compare June 12, 2024 12:08
@MarIniOnz MarIniOnz force-pushed the 65-refactor-treatment-effect branch 3 times, most recently from 1a87a42 to f154fa7 Compare June 18, 2024 13:43
@MarIniOnz MarIniOnz force-pushed the 65-refactor-treatment-effect branch 10 times, most recently from 0b288f0 to 0dca224 Compare June 19, 2024 12:23
@MarIniOnz MarIniOnz force-pushed the 65-refactor-treatment-effect branch from 0dca224 to 7a4a765 Compare June 19, 2024 12:27
@JabobKrauskopf
Copy link
Member

This branch should no longer be used. Work should continue in #111

@JabobKrauskopf JabobKrauskopf deleted the 65-refactor-treatment-effect branch July 8, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JabobKrauskopf JabobKrauskopf JabobKrauskopf left review comments

@OFranke OFranke Awaiting requested review from OFranke OFranke is a code owner automatically assigned from limebit/medmodels-software-engineering

@FloLimebit FloLimebit Awaiting requested review from FloLimebit FloLimebit is a code owner automatically assigned from limebit/medmodels-software-engineering

@philippgrosser philippgrosser Awaiting requested review from philippgrosser philippgrosser is a code owner automatically assigned from limebit/medmodels-data-science-team

@LauraBoenchenLB LauraBoenchenLB Awaiting requested review from LauraBoenchenLB LauraBoenchenLB is a code owner automatically assigned from limebit/medmodels-data-science-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Treatment Effect
2 participants
@MarIniOnz @JabobKrauskopf