add drop options to email_routing_rule

Detail ====== - the `action` should be one of `forward`, `worker`, `drop`, but there was no `drop` in latest provider. - ref: cloudflare#1947
limejuny · Nov 21, 2023 · 4c91c1d · 4c91c1d
1 parent 3b75169
commit 4c91c1d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/internal/sdkv2provider/resource_cloudflare_email_routing_rule.go b/internal/sdkv2provider/resource_cloudflare_email_routing_rule.go
@@ -46,8 +46,10 @@ func buildMatchersAndActions(d *schema.ResourceData) (matchers []cloudflare.Emai
 			action := item.(map[string]interface{})
 			ruleAction := cloudflare.EmailRoutingRuleAction{}
 			ruleAction.Type = action["type"].(string)
-			for _, value := range action["value"].([]interface{}) {
-				ruleAction.Value = append(ruleAction.Value, value.(string))
+			if val, ok := action["value"]; ok {
+				for _, value := range val.([]interface{}) {
+					ruleAction.Value = append(ruleAction.Value, value.(string))
+				}
 			}
 
 			actions = append(actions, ruleAction)

diff --git a/internal/sdkv2provider/schema_cloudflare_email_routing_rules.go b/internal/sdkv2provider/schema_cloudflare_email_routing_rules.go
@@ -71,7 +71,7 @@ func resourceCloudflareEmailRoutingRuleSchema() map[string]*schema.Schema {
 						Description:  "Type of supported action.",
 						Type:         schema.TypeString,
 						Required:     true,
-						ValidateFunc: validation.StringInSlice([]string{"forward", "worker"}, true),
+						ValidateFunc: validation.StringInSlice([]string{"forward", "worker", "drop"}, true),
 					},
 					"value": {
 						Description: "An array with items in the following form.",