Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make document ID URL-safe + UUID support + refactorings #15

Merged
merged 8 commits into from
Mar 25, 2023

Conversation

limenet
Copy link
Owner

@limenet limenet commented Mar 25, 2023

No description provided.

@limenet limenet self-assigned this Mar 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Patch coverage: 96.96% and project coverage change: +0.07 🎉

Comparison is base (d873381) 85.37% compared to head (cc0fab7) 85.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #15      +/-   ##
============================================
+ Coverage     85.37%   85.45%   +0.07%     
+ Complexity      125      123       -2     
============================================
  Files            18       18              
  Lines           383      385       +2     
============================================
+ Hits            327      329       +2     
  Misses           56       56              
Impacted Files Coverage Δ
src/Commands/DeleteCommand.php 8.33% <ø> (ø)
src/Commands/IndexCommand.php 79.41% <ø> (ø)
src/Events/EventHandler.php 76.47% <ø> (ø)
src/Jobs/AbstractIndexJob.php 100.00% <ø> (ø)
src/Repository/IndexRepository.php 100.00% <ø> (ø)
src/Commands/StatusCommand.php 96.49% <66.66%> (ø)
src/Client/ElasticaClient.php 100.00% <100.00%> (ø)
src/Index/AbstractIndex.php 95.00% <100.00%> (+0.12%) ⬆️
src/Jobs/ActivateIndex.php 100.00% <100.00%> (ø)
src/Jobs/PopulateBatchIndex.php 70.58% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@limenet limenet changed the title Make document ID URL-safe + refactorings Make document ID URL-safe + UUID support + refactorings Mar 25, 2023
@limenet limenet merged commit 6f9337d into main Mar 25, 2023
@limenet limenet deleted the refactor-document-id branch March 25, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants