Empty output, division by zero

limix · Jun 28, 2019 · 38dcc31 · 38dcc31
1 parent 72251ba
commit 38dcc31
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/glimix_core/_util/solve.py b/glimix_core/_util/solve.py
@@ -59,7 +59,7 @@ def heigvals(a, b, d):
     D = a * d - b * b
 
     t0 = T / 2
-    t1 = sqrt(T * T / 4 - D)
+    t1 = sqrt(maximum(T * T / 4 - D, 0))
     eig0 = t0 + t1
     eig1 = t0 - t1
 

diff --git a/glimix_core/lmm/_lmm.py b/glimix_core/lmm/_lmm.py
@@ -13,9 +13,9 @@
 )
 from numpy.linalg import inv, lstsq, slogdet
 from numpy_sugar import epsilon
-from optimix import Function, Scalar
 
 from glimix_core._util import cache, log2pi
+from optimix import Function, Scalar
 
 from .._util import economic_qs_zeros, numbers
 from ._lmm_scan import FastScanner
@@ -140,6 +140,9 @@ def __init__(self, y, X, QS=None, restricted=False):
         if not is_all_finite(y):
             raise ValueError("There are non-finite values in the outcome.")
 
+        if len(y) == 0:
+            raise ValueError("The outcome array is empty.")
+
         X = atleast_2d(asarray(X, float).T).T
         if not is_all_finite(X):
             raise ValueError("There are non-finite values in the covariates matrix.")