Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem closing the modal in Android's default browser #673

Closed
lucas-jc opened this issue Oct 21, 2017 · 7 comments
Closed

Problem closing the modal in Android's default browser #673

lucas-jc opened this issue Oct 21, 2017 · 7 comments
Labels
type: bug If the bug is not reproducible, ask for clarifications, and close after a week if no news are given

Comments

@lucas-jc
Copy link

lucas-jc commented Oct 21, 2017

I'm having trouble closing the modal using the standard android browser.

The test was:
1- Open the site https://sweetalert2.github.io/ in the Android browser. (I used AVD API 22 / Android 5.1 and another test in Asus Zenfone 2 Android 5.0)
2- Click the "Show success message"
3- Click the "OK" button. The modal does not close. :(

No errors were shown on the console. I already tried to use core-js and it still did not work.

Thank you.

@limonte limonte added the type: bug If the bug is not reproducible, ask for clarifications, and close after a week if no news are given label Oct 23, 2017
@limonte
Copy link
Member

limonte commented Oct 24, 2017

For some reason, this is related only to all.min.js version. I replaced it with regular .js + .css files and everything works fine now.

@lucas-jc could you please verify that https://sweetalert2.github.io/ works for your device, thanks in advance!

@lucas-jc
Copy link
Author

Nice @limonte ! All working now.

Thanks!

@limonte
Copy link
Member

limonte commented Oct 27, 2017

Great, thanks for the feedback, but let's not close the issue just now :) We need to figure out what is wrong with all.min.js and why it doesn't work with Android browser. My guess - the CSS injecting doesn't have a proper browsers support.

@limonte
Copy link
Member

limonte commented Oct 29, 2017

Gotcha! The issue is happening because of missing webkit- and other prefixes. I can't figure out how to add autoprefixer before injecting CSS, @samturrell could you please help with adding autoprefixer?

@samturrell
Copy link
Contributor

I'll take a look!

@limonte
Copy link
Member

limonte commented Oct 30, 2017

Thanks @samturrell! This is the last standing issue which will be released as 6.11.3. After that - the next major 🎉

@limonte
Copy link
Member

limonte commented Oct 30, 2017

Fixed in v6.11.3, thanks @lucas-jc for reporting!

@limonte limonte mentioned this issue Jan 21, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug If the bug is not reproducible, ask for clarifications, and close after a week if no news are given
Projects
None yet
Development

No branches or pull requests

3 participants