Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic for drum RandomPad is wrong in 6-lane mode #116

Closed
sakamoto-neko opened this issue Dec 24, 2021 · 1 comment
Closed

Logic for drum RandomPad is wrong in 6-lane mode #116

sakamoto-neko opened this issue Dec 24, 2021 · 1 comment
Labels

Comments

@sakamoto-neko
Copy link
Collaborator

Shown here is Hoshi no Kakera with RandomPad set to "On" and NumOfLanes set to "6". When these settings are applied, the low-tom roll becomes an alternating hi-tom/low-tom roll as shown here: https://youtu.be/VIMPTc1R5II

This should be the correct effect, in another fork of DTXMania: https://youtu.be/9tk0eQnaPaU
The link for this particular fork is here: http://www.mediafire.com/?t6m8r9m2wkv9v

@limyz limyz added the bug label Dec 28, 2021
@fisyher
Copy link
Collaborator

fisyher commented Feb 19, 2024

This bug has nothing to do with any Random option but has to do with the fact that Low Tom are always mapped to alternating Low and High-Toms when NumOfLanes is set to "6" aka Classic Mode.

An easy way to reproduce is simply create a chart with all Low-Toms and play it in Classic Mode.

Code that causes this effect is in CDTX.cs around Line 2125:

...
case EChannel.LowTom:
  if (num5 != chip.nPlaybackPosition)
  {
	  if (flag)
	  {
		  chip.nChannelNumber = EChannel.HighTom;
	  }
  }
  if (num3 == EChannel.LowTom)
  {
	  chip.nChannelNumber = EChannel.HighTom; //This line
  }
  num3 = chip.nChannelNumber;
  num5 = chip.nPlaybackPosition;
  continue;

I have also cross-checked with the original ver K source code and found the same behaviour so this has been there all along, at least since ver K.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants