Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed feature: loop capability #38

Closed
ericpignet opened this issue Aug 21, 2020 · 2 comments · Fixed by #42
Closed

Proposed feature: loop capability #38

ericpignet opened this issue Aug 21, 2020 · 2 comments · Fixed by #42

Comments

@ericpignet
Copy link
Collaborator

ericpignet commented Aug 21, 2020

I'd like to have a loop feature, as we can see in Rocksmith, or Yousician for those who know: you select the few bars that you want to practice and it's looping on those bars forever.
In case a loop is used, the song would be come in 'training' mode and stats stop being recorded.

I've already started working on this, I have some experimental code.
The main problems are:

  • I didn't manage to make it work with DirectSound. It only works with WASAPI or ASIO
  • Code is on my English language branch so it may be a bit hard to backport to the Japanese source code

Eric

@limyz
Copy link
Owner

limyz commented Aug 21, 2020

This is an awesome feature to have and most users should be using WASAPI or ASIO for latency anyway

@ericpignet
Copy link
Collaborator Author

FYI I think the functionality is ready. At least it does the job and seems stable. Obviously we can enhance later on based on user feedback.
But as expected it's pretty big and I don't feel like backporting it in a Japanese branch, it would be a lot of work, so for now I'm waiting that we progress on issue #4 .

@limyz limyz linked a pull request Sep 6, 2020 that will close this issue
@limyz limyz closed this as completed Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants