-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate code to English #4
Comments
I have big difficulties to read code in Japanese (forgot most of my Japanese lessons in uni, except katakana). Would you accept a pull request with a huge lot of translations to English on master branch? |
This has been initially raised as a concern since 2016, feel free to raise a PR and we will do a merge immediately |
Yes, you are right that it may cause problems importing upstream fixes, it may also cause major merge conflicts with my other branch if the variables, class and function names are renamed directly. Perhaps another way is to add their translated names in a line comment above each of them? |
It would be possible to add translations as comments above class/functions/variables but I'm not sure how much it would help readability, at least for people who can't speak Japanese at all. The body of all functions would still be in Japanese. My questions are:
For now I can keep my branch on the side. If you want you can create an 'english' branch on the limyz project and I would merge my 'english' branch to this one. It's really up to you. |
Attempts to contact @kairera0467 (https://twitter.com/kairera0467) over GitHub or Twitter is lacklustre at best. Upstream fixes will largely depend on commits made by kairera in the verk svn (See https://osdn.net/projects/dtxmaniaxg-verk/scm/git/dtxmaniaxg-verk-git). The 4.x branch is severely bugged, probably due to a deviation from the SlimDX libraries (DirectX 9 is rather old) and is incompatible with the current branch. I doubt we will work on this branch in the foreseeable future. We can also look at current forks of DTXMania as of date (e.g DTXMania2, DTXMania AL) Sadly, DTXAL has not disclosed its source code. |
Understood. So what's the plan for English translation? |
Our primary concerns are still upstream fixes from the svn and here's our options:
The latter option also allows easier merging of code from other forks. (reverse engineering DTXMania AL shows very similar file and folder structures). |
The SQLite config branch is just a proof-of-concept branch to test if config.ini can be replaced with a config.sqlite file, which I don't plan to merge back anytime soon. I think we should wrap up the English translation branch first, then PR merge back before we continue any feature / enhancement work since the changes in the English branch are HUGE On a side note, I used this to translate Japanese code and comments as recommended by @sakamoto-neko https://www.deepl.com/en/translator @limyz Translated code with original Japanese names in comments work too. Can consider that as an option |
Hi, So what do I do? Can I propose a pull request to your master branch (when I'm ready)? you can do a Japanese branch from the revision just before English translation if you want. Also, just throwing ideas here, we mentioned in the Discord server creating an English language DTXMania wiki on Github. We could create a new Github Organisation (project managed by mutliple people) for DTXMania international community and host the English branch there as well as the wiki. @limyz could keep the release management but we would all have rights to manage branches and review/merge each other's pull request. |
Before proposing a pull request, please also update the DTXCreator solution with the changes you have made for FDK. It is currently not build-able. |
Yes sure. What's on Github at the moment is some work in progress, a bit old. For DTXCreator I have integrated the changes done in FDK and translated the file names and classes, but I've not translated the classes/methods/file names. |
No description provided.
The text was updated successfully, but these errors were encountered: