Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Stage Clear" audio is played instead of "Full Combo" or "Excellent" when FC or EXC #15

Closed
approvedtx opened this issue May 16, 2016 · 4 comments
Closed

"Stage Clear" audio is played instead of "Full Combo" or "Excellent" when FC or EXC #15

approvedtx opened this issue May 16, 2016 · 4 comments
Assignees
@approvedtx
Labels
enhancement

Comments

@approvedtx
Copy link
Collaborator

No description provided.

@fisyher
Copy link
Collaborator

fisyher commented May 20, 2016

WJ, I don't have the sound clips for Gitadora "Excellent" to add into a branch. Why don't you create a new branch from Master and add the sound clip to the new Branch first? I can try to find out where in the code to play the "Excellent" sound :)

@limyz
Copy link
Owner

limyz commented May 21, 2016 •
edited
Loading

Thanks to e1161b2, wj added new audio files for use.
6ebb414 resolves the "Excellent" audio issue.

@limyz
Copy link
Owner

limyz commented May 21, 2016

4b0dcce resolves the "Full Combo" audio issue.

@limyz
Copy link
Owner

limyz commented May 21, 2016 •
edited
Loading

72a3e09 now completely resolves the issue, ensuring that the FC/EXC audio is not heard when even an auto accompaniment is used. Refer to #20 for the PR

@limyz limyz closed this as completed May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@approvedtx approvedtx

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@limyz @fisyher @approvedtx