Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IC SD2 from MATLAB version #135

Open
Andesha opened this issue Jun 8, 2023 · 5 comments
Open

IC SD2 from MATLAB version #135

Andesha opened this issue Jun 8, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Andesha
Copy link
Contributor

Andesha commented Jun 8, 2023

Working data, I've been seeing that the IC SD2 from the MATLAB version really helps to mark out those last few periods of artifacts.

We currently only do the one pass, but it does exist in the previous.

See here.

@scott-huberty
Copy link
Member

So just to clarify. In this case:

We would run the final ICA (in our case info max).

We run flag_epochs_ic_sd on the final ICA time series, where any flagged epochs are labeled ic_sd_2

This last assessment would not have any impact on the ICA topos obv because we aren't running another ICA afterwards.

The only impact of this assessment is to flag more epochs in the raw data, with bad_pylossless_ic_sd2

Is that right?

@Andesha
Copy link
Contributor Author

Andesha commented Jun 13, 2023

Yep, that's right.

It's just doing an additional flagging of bad time via exactly what you outlined

@scott-huberty
Copy link
Member

Okay cool, if you'd like this step and it was in the original pipeline Im +1 for adding this extra step.

@Andesha if you'd like this feature are you up for a PR? I won't have time to implement it myself in the near future.

I think we can just re-use the flag_epoch_ic_sd or whatever it's called and place it after the final ica. We can create a parameter like flag_label with default ic_sd1 but for this new second call we can change it to something else. This flag_label parameter should get passed in to add_pylossless_annotation

I think there are a few nested funcs that will need this new flag_label kwarg but seems do able to me.

@Andesha
Copy link
Contributor Author

Andesha commented Jun 14, 2023

I'll give it a try at some point - could you create it as an issue and assign it to me?

@scott-huberty
Copy link
Member

I'll give it a try at some point - could you create it as an issue and assign it to me?

Done ;)

@scott-huberty scott-huberty added the enhancement New feature or request label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants