Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Multi-modal recordings #64

Open
scott-huberty opened this issue Mar 16, 2023 · 2 comments
Open

Handling Multi-modal recordings #64

scott-huberty opened this issue Mar 16, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@scott-huberty
Copy link
Member

scott-huberty commented Mar 16, 2023

if I run this

import pylossless as ll 
import mne
fname = mne.datasets.sample.data_path() / 'MEG' / 'sample' /  'sample_audvis_raw.fif'
raw = mne.io.read_raw_fif(fname, preload=True).pick_types(eeg=True)  # Without explicit exclusion of MEG chans the pipeline breaks. Must fix.

config = ll.config.Config()
config.load_default()
config.save("my_project_ll_config.yaml")

pipeline = ll.LosslessPipeline('my_project_ll_config.yaml')
pipeline.run_with_raw(raw)

If I don't explicitly pick eeg channels like in line 4, the pipeline will flag all channels in flag_ch_outliers and fail.
This is especially problematic for users who run the pipeline from a BIDS path, and don't have the option to pick eeg chans.

EDIT: this is likely the same underlying issue that caused #56

@scott-huberty scott-huberty added the bug Something isn't working label Mar 16, 2023
@christian-oreilly
Copy link
Collaborator

I'd suggest adding something to the config file to define which channels types should be included, maybe with a default behavior to "EEG" and "MEG? We should definitely not have to pick_types explicitly like that for basic usage.

@christian-oreilly christian-oreilly added enhancement New feature or request and removed bug Something isn't working labels Apr 29, 2023
@christian-oreilly
Copy link
Collaborator

Upgraded from bug to enhancement. The bug was fixed by PR #92, which explicitly operates only on EEG. The enhancement would require, e.g., specifying modalities (EEG, MEG, ...) to be included as part of the config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants