Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create channel > Missing option "Automatically invite all workspace users to this channel" when creating a public channel #880

Closed
tlle14 opened this issue Sep 6, 2021 · 14 comments · Fixed by #1050
Assignees
Labels
bug Something isn't working Major QA - Bug priority

Comments

@tlle14
Copy link
Contributor

tlle14 commented Sep 6, 2021

Precondition

Creating public channel

Actual Result

When creating a public channel, there is missing the option "Automatically invite all workspace users to this channel" as on the Web version
Mobile:
screenshot_20

Web:
screenshot_21

Expected Result

There should have an option "Automatically invite all workspace users to this channel" as on the web version

Environment

Build version: 3.0.6
Device:
Samsung Galaxy A51 - Android 11 - 6.5 inch
QA environment

@tlle14 tlle14 added bug Something isn't working Major QA - Bug priority labels Sep 6, 2021
@tlle14
Copy link
Contributor Author

tlle14 commented Sep 6, 2021

@shivam9593 Hi, you can track the issue here

@BastiaanVanGaalen
Copy link

@bmuddha
Copy link
Contributor

bmuddha commented Sep 13, 2021

@RomaricMourgues hello, what is the flag in the following API request to include all members of workspace in the newly created channel?
https://www.notion.so/twake/REST-Api-Websockets-Api-458b153a6a6e46c2925dfc1db3859d3b

@RomaricMourgues
Copy link
Contributor

This is the "default" flag

@bmuddha
Copy link
Contributor

bmuddha commented Sep 15, 2021

@RomaricMourgues, I've created a channel with default flag set to true, and no existing user in the current workspace was added to this channel, so I suppose that default flag is set only for the new users joining the workspace not for already existing ones

@bmuddha
Copy link
Contributor

bmuddha commented Sep 16, 2021

@RomaricMourgues any ideas?

@RomaricMourgues
Copy link
Contributor

Of course this is a bug then, I'll check

@RomaricMourgues
Copy link
Contributor

Could you give me the environment you tried on ? I just tested now and it was working (both when editing channel and when creating channel with default parameter).
Maybe we fixed it in the last days but not sure.

@bmuddha
Copy link
Contributor

bmuddha commented Sep 24, 2021

It's QA environment, a workspace has a 5 members, when creating a new channel the default flag is set, and all 5 members supposed to automatically to be added to channel, but the channel has only 1 member as a result

@hoangdat
Copy link
Member

hoangdat commented Nov 4, 2021

@tlle14 please verify it, it is available in latest version.

@tlle14
Copy link
Contributor Author

tlle14 commented Nov 4, 2021

Hi @hoangdat the option is displayed in the latest version, but it doesn't work.
Please fix.

original-80CD12E7-0FAA-4DAA-AFF3-6699559ED7D5.mp4

hoangdat added a commit to hoangdat/Twake-Mobile that referenced this issue Nov 4, 2021
@hoangdat hoangdat linked a pull request Nov 4, 2021 that will close this issue
@hoangdat hoangdat self-assigned this Nov 8, 2021
EvGen94 added a commit that referenced this issue Nov 8, 2021
Auto add all members optional while creating channel (#880)
@tlle14 tlle14 reopened this Nov 15, 2021
@hoangdat
Copy link
Member

@tlle14 why you reopen this, please comment when you take any action like close/reopen

@tlle14
Copy link
Contributor Author

tlle14 commented Nov 15, 2021

Hi @hoangdat this issue is not retested before it was closed.
Please move it to the QA testing column for retesting in the next build (if it is ready)

@tlle14
Copy link
Contributor Author

tlle14 commented Nov 25, 2021

Thanks,
Retest pass!

RPReplay_Final1637833251.mp4

@tlle14 tlle14 closed this as completed Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Major QA - Bug priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants