Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "direct_channel_members" fields returned by channels resource #856

Closed
RomaricMourgues opened this issue Feb 1, 2021 · 1 comment
Assignees
Labels

Comments

@RomaricMourgues
Copy link
Contributor

We should always get a proper direct_channel_members in channels:

If channel is direct: direct_channel_members contains the users of the direct channel

Else: direct_channel_members is an empty list

@chamerling
Copy link
Contributor

After discussion, we choose to keep members array for every channel to be consistant. We will do the switch on the frontend based on the channel type (public, private, direct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants