Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#52 fix translation #54

Merged
merged 2 commits into from
Aug 13, 2020
Merged

#52 fix translation #54

merged 2 commits into from
Aug 13, 2020

Conversation

tuanlc
Copy link

@tuanlc tuanlc commented Aug 12, 2020

No description provided.

@tuanlc tuanlc added this to In progress in Split Polish via automation Aug 12, 2020
@tuanlc tuanlc linked an issue Aug 12, 2020 that may be closed by this pull request
@tuanlc tuanlc changed the title #52 #52 fix translation Aug 12, 2020
@piavgh
Copy link

piavgh commented Aug 12, 2020

There are conflicting files:

src/linagora.esn.unifiedinbox/i18n/en.json
src/linagora.esn.unifiedinbox/i18n/fr.json
src/linagora.esn.unifiedinbox/i18n/ru.json
src/linagora.esn.unifiedinbox/i18n/vi.json
src/linagora.esn.unifiedinbox/i18n/zh.json

Tuan Tuan LE added 2 commits August 12, 2020 17:25
Adapt new version of esnI18nService.translate method in common libs
@itswillta
Copy link
Contributor

Where do these {{ text }} come from? I don't see them reflected in the changed code.

@itswillta itswillta moved this from In progress to Review in progress in Split Polish Aug 12, 2020
@tuanlc
Copy link
Author

tuanlc commented Aug 12, 2020

Where do these {{ text }} come from? I don't see them reflected in the changed code.

Here: src/linagora.esn.unifiedinbox/app/services/mailboxes-filter/mailboxes-filter-service.js

Split Polish automation moved this from Review in progress to Reviewer approved Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt new version of esnI18nService.translate method in common libs
3 participants