WIP MailboxManager::search #1008

chibenwa · 2017-10-03T11:42:20Z

No description provided.

…nctional way

…dling

…ng for now

…es property

…filtering for now

…r rights

…ath handling

setMailboxId is a Mailbox method already

…pper

…user

- Allow missing namespace and username in mailboxQuery - Matching logic SHOULD be moved in MailboxQuery

mbaechler · 2017-10-03T12:42:59Z

mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java

-        List<MailboxMetaData> metaDatas = mailboxManager.search(new MailboxQuery(MailboxPath.forUser(USER_1, ""), "*", '.'), session);
+        List<MailboxMetaData> metaDatas = mailboxManager.search(
+                MailboxQuery.builder()
+                    .base(MailboxPath.forUser(USER_1, ""))


we should probably introduce something else than MailboxPath for something that can't be a mailbox path (empty string is probably not legal)

mbaechler · 2017-10-03T12:43:53Z

mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java

+        List<MailboxMetaData> metaDatas = mailboxManager.search(
+                MailboxQuery.builder()
+                    .base(MailboxPath.forUser(USER_1, ""))
+                    .expression("*")


should be matchesAll

mbaechler · 2017-10-03T12:47:39Z

mailbox/api/src/main/java/org/apache/james/mailbox/model/MailboxACL.java

@@ -503,6 +503,10 @@ public String serialize() {
        public String toString() {
            return serialize();
        }
+
+        public boolean isUser() {


there's already getNameType

mbaechler · 2017-10-03T12:48:52Z

mailbox/api/src/main/java/org/apache/james/mailbox/model/MailboxACL.java

+    public Map<String, Rfc4314Rights> usersACL() {
+        return this.entries.entrySet().stream()
+            .filter(entry -> entry.getKey().isUser())
+            .map(entry -> Pair.of(entry.getKey().getName(), entry.getValue()))


Guavate.entriesToMap

mbaechler · 2017-10-03T12:49:19Z

mailbox/api/src/main/java/org/apache/james/mailbox/model/MailboxACL.java

@@ -878,4 +882,10 @@ public MailboxACL union(EntryKey key, Rfc4314Rights mailboxACLRights) throws Uns
        return union(new MailboxACL(new Entry(key, mailboxACLRights)));
    }

+    public Map<String, Rfc4314Rights> usersACL() {


why don't we take NameType as argument for filtering ?

Also added "rejection of (unhandled) negative entries in ACL".

mbaechler · 2017-10-03T12:59:46Z

mailbox/api/src/main/java/org/apache/james/mailbox/model/MailboxQuery.java

        pattern = constructEscapedRegex();
    }

+    public MailboxPath getPathLike() {


but it's not a MailboxPath

A refactoring solved this.

mbaechler · 2017-10-03T13:00:52Z

mailbox/api/src/main/java/org/apache/james/mailbox/model/MailboxQuery.java

+
+        return belongsToRequestedNamespaceAndUser(mailboxPath)
+            && mailboxName.startsWith(baseName)
+            && isExpressionMatch(mailboxName.substring(baseNameLength));


we are still doing substrings ?

A refactoring solved this.

mbaechler · 2017-10-03T13:05:07Z

mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerTest.java

+        MailboxPath inbox1 = MailboxPath.inbox(session1);
+        mailboxManager.createMailbox(inbox1, session1);
+        mailboxManager.setRights(inbox1,
+            new MailboxACL(


there's a great builder for that

mbaechler · 2017-10-03T13:18:45Z

.../cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxMapper.java

@@ -218,12 +222,17 @@ public boolean hasChildren(Mailbox mailbox, char delimiter) {
    public void updateACL(Mailbox mailbox, MailboxACL.ACLCommand mailboxACLCommand) throws MailboxException {
        CassandraId cassandraId = (CassandraId) mailbox.getMailboxId();
        cassandraACLMapper.updateACL(cassandraId, mailboxACLCommand);
+        if (mailboxACLCommand.getEntryKey().isUser()) {


In my opinion, we lack an ACLChangedEvent that is triggered on ACL changes. With that event, we could handle these ACL updates (and projections building) based on events

IMO we don't need it now. Cassandra DAO consistency is very well handled without.

Thus I would advise to do it later to avoid unecessary big refactoring

mbaechler · 2017-10-03T13:20:26Z

...dra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraUserMailboxRightsDAO.java

+                rowOptional.map(Throwing.function(row -> Rfc4314Rights.fromSerializedRfc4314Rights(row.getString(RIGHTS)))));
+    }
+
+    public CompletableFuture<Map<MailboxId, Rfc4314Rights>> retrieveUser(String userName) {


listRightsForUser

chibenwa · 2017-10-04T11:43:01Z

See #1011

This commit also adds a minimal README.md to be improved with more detailed deployment instructions in the future.

mbaechler and others added 30 commits October 3, 2017 09:23

JAMES-2169 rename username to alice before adding a new user

55b8709

JAMES-2169 MailboxProbe.createMailbox should return a MailboxId

f5f12d2

JAMES-2169 rely on createMailbox return, don't call getMailbox

94b2fa5

JAMES-2169 refactor GetMailboxesMethod.retrieveMailboxes in a more fu…

2a23a97

…nctional way

JAMES-2169 Introduce MailboxPath::forUser to simplify MailboxPath han…

fc86c25

…dling

JAMES-2169 first simple sharing test case, missing sharedWith filteri…

22a1b77

…ng for now

JAMES-2169 enhance development experience by adding logs on failure

d181ff2

JAMES-2169 introduce MailboxACL.command() to ease ACLCommand usage

b46be84

JAMES-2169 fix a typo on MailboxMetaData.permanentFlags

738082b

JAMES-2169 MailboxMetaData small refactoring for Java 8 style

58a70ba

JAMES-2169 move fixture to be able to use it widely

02c796e

JAMES-2169 implement Mailbox.sharedWith filtering based on user rights

ab1f8e7

JAMES-2169 Various JMAP integration testing improvements

14f9209

JAMES-2169 Add a test checking ADMIN can read sharedWith JMAP Mailbox…

76f7587

…es property

JAMES-2169 Use MailboxPath::forUser more widely

f8758bb

fixup! JAMES-2169 first simple sharing test case, missing sharedWith …

91086f5

…filtering for now

fixup! JAMES-2169 implement Mailbox.sharedWith filtering based on use…

467f97e

…r rights

fixup! JAMES-2169 implement Mailbox.sharedWith filtering based on use…

3ccb623

…r rights

fixup! JAMES-2169 implement Mailbox.sharedWith filtering based on use…

af60732

…r rights

fixup! JAMES-2169 Introduce MailboxPath::forUser to simplify MailboxP…

3915748

…ath handling

JAMES-2169 Improve MailboxACL.EntryKey create* static methods wording

c5d88e3

JAMES-2169 Remove unneeded cast (intelliJ Warning)

b18be6e

setMailboxId is a Mailbox method already

fixup! JAMES-2169 MailboxProbe.createMailbox should return a MailboxId

738bfd1

JAMES-2169 Rename confusing optional method

9b89583

fixup! JAMES-2169 Use MailboxPath::forUser more widely

7d4119a

MAILBOX-307 CassandraACLMapper should not be initialized in MailboxMa…

5456c60

…pper

linagora#327 Don't expose MailboxQuery constructor

582bee9

linagora#327 Introduce Cassandra DAO for tracking rights by mailbox/…

748912a

…user

linagora#327 MailboxACL should present only users ACL

93b888d

linagora#327 Mapper should store the ACL by user/mailbox

a3d5ce0

aduprat and others added 12 commits October 3, 2017 18:39

linagora#327 Introduce Right search capability

4f0bfc3

WIP mapper should return mailbox + memory implem

e85b845

Correct and add Mapper level tests

8acfaf8

More mapper tests

3ba7128

Cassandra modseq and uid test don't need mailbox mapper

32c304a

Another mapper test

1281695

Introduce ACLChange object

de92474

Cassandra implementation should pass mapper tests

d221aba

Refactor mailbox search

89547cf

- Allow missing namespace and username in mailboxQuery - Matching logic SHOULD be moved in MailboxQuery

MailboxMapper not supporting delegation should return empty

2406037

InMemory should support right search

0a651e2

MailboxManager::search should allow retrieving delegated mailboxes

1044d47

mbaechler reviewed Oct 3, 2017

View reviewed changes

chibenwa closed this Oct 4, 2017

quantranhong1999 pushed a commit to quantranhong1999/james-project that referenced this pull request May 24, 2022

[JAMES-3767] rename pulsar artifact (linagora#1008)

f00f17d

This commit also adds a minimal README.md to be improved with more detailed deployment instructions in the future.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP MailboxManager::search #1008

WIP MailboxManager::search #1008

chibenwa commented Oct 3, 2017

mbaechler Oct 3, 2017

chibenwa Oct 4, 2017

mbaechler Oct 3, 2017

chibenwa Oct 4, 2017

mbaechler Oct 3, 2017

mbaechler Oct 3, 2017

mbaechler Oct 3, 2017

chibenwa Oct 4, 2017

mbaechler Oct 3, 2017

chibenwa Oct 4, 2017

mbaechler Oct 3, 2017

chibenwa Oct 4, 2017

mbaechler Oct 3, 2017

mbaechler Oct 3, 2017

chibenwa Oct 4, 2017

mbaechler Oct 3, 2017

chibenwa commented Oct 4, 2017

WIP MailboxManager::search #1008

WIP MailboxManager::search #1008

Conversation

chibenwa commented Oct 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chibenwa commented Oct 4, 2017