JAMES-2558 Tests should rely on SpamAssassin 3.4.2 #1793

chibenwa · 2018-10-10T07:53:33Z

Fixes CVE-2017-15705, CVE-2016-1238, CVE-2018-11780 & CVE-2018-11781

chibenwa · 2018-10-10T08:57:27Z

[fb95fe1e714c712cc6e40ea95a28138aa037bff4] Caused by: com.github.dockerjava.api.exception.DockerClientException: Could not build image: The command '/bin/sh -c apt-get update &&     DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y         gpg         libio-socket-ip-perl         libmail-dkim-perl         libnet-ident-perl         libsocket-getaddrinfo-perl         pyzor         razor         libdbi-perl         libdbd-pg-perl         spamassassin=${SPAMASSASSIN_VERSION}* &&     apt-get clean &&     rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100

Packaging not yet available exception?

chibenwa · 2018-10-10T09:06:38Z

The container inherit Debian Stretch from the postgres container https://github.com/docker-library/postgres/blob/3f585c58df93e93b730c09a13e8904b96fa20c58/10/Dockerfile

But stretch is only 3.4.1 based cf https://packages.debian.org/fr/spamassassin

Switching to testing or unstable do not seem wize.

Maybe we should curl + dpkg some trusted 3.4.2 package over the internet (or update our APT lists)

chibenwa · 2018-10-11T02:38:31Z

This should be done in the following days : https://tracker.debian.org/pkg/spamassassin

We can monitor progress here...

trantienduchn · 2018-10-12T06:55:51Z

test this please

trantienduchn · 2018-10-12T09:34:01Z

[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR] Errors: 
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR]   SpamAssassinInvokerTest.learnAsHamShouldAllowToForgetSpam » ContainerFetch Can...
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR]   SpamAssassinInvokerTest.learnAsHamShouldReturnTrueWhenLearningWorks » ContainerFetch
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR]   SpamAssassinInvokerTest.learnAsSpamShouldReturnTrueWhenLearningWorks » ContainerFetch
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsHamWhenMessageAlreadyLearnedAsHam » ContainerFetch
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenKnownAsSpam » ContainerFetch
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenMessageAlreadyLearnedAsSpam » ContainerFetch
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyHeadersField » ContainerFetch Can'...
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyHitsField » ContainerFetch Can't g...
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyRequiredHitsField » ContainerFetch
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [INFO] 
[fb95fe1e714c712cc6e40ea95a28138aa037bff4] [ERROR] Tests run: 14, Failures: 0, Errors: 9, Skipped: 0

chibenwa · 2018-10-12T09:36:37Z

Yes no need to relaunch it, the debian package is not yet available

chibenwa · 2018-10-24T04:33:30Z

test this please

(just to have a failing build report instead of an inapropriate pending build report, packaging is still not yet available...)

trantienduchn · 2018-10-24T07:59:24Z

here you are

[null] Tests in error: 
[null]   SpamAssassinInvokerTest.learnAsHamShouldAllowToForgetSpam » ContainerFetch Can...
[null]   SpamAssassinInvokerTest.learnAsHamShouldReturnTrueWhenLearningWorks » ContainerFetch
[null]   SpamAssassinInvokerTest.learnAsSpamShouldReturnTrueWhenLearningWorks » ContainerFetch
[null]   SpamAssassinInvokerTest.scanMailShouldMarkAsHamWhenMessageAlreadyLearnedAsHam » ContainerFetch
[null]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenKnownAsSpam » ContainerFetch
[null]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenMessageAlreadyLearnedAsSpam » ContainerFetch
[null]   SpamAssassinInvokerTest.scanMailShouldModifyHeadersField » ContainerFetch Can'...
[null]   SpamAssassinInvokerTest.scanMailShouldModifyHitsField » ContainerFetch Can't g...
[null]   SpamAssassinInvokerTest.scanMailShouldModifyRequiredHitsField » ContainerFetch
[null] 
[null] Tests run: 111, Failures: 0, Errors: 9, Skipped: 0

chibenwa · 2018-11-05T08:03:10Z

test this please

trantienduchn · 2018-11-05T10:33:57Z

[ba6fa212f3e3857376b43b3714c65dfd32cd063c] [ERROR]   SpamAssassinInvokerTest.learnAsHamShouldAllowToForgetSpam » ContainerFetch Can...
[ba6fa212f3e3857376b43b3714c65dfd32cd063c] [ERROR]   SpamAssassinInvokerTest.learnAsHamShouldReturnTrueWhenLearningWorks » ContainerFetch
[ba6fa212f3e3857376b43b3714c65dfd32cd063c] [ERROR]   SpamAssassinInvokerTest.learnAsSpamShouldReturnTrueWhenLearningWorks » ContainerFetch
[ba6fa212f3e3857376b43b3714c65dfd32cd063c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsHamWhenMessageAlreadyLearnedAsHam » ContainerFetch
[ba6fa212f3e3857376b43b3714c65dfd32cd063c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenKnownAsSpam » ContainerFetch
[ba6fa212f3e3857376b43b3714c65dfd32cd063c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenMessageAlreadyLearnedAsSpam » ContainerFetch
[ba6fa212f3e3857376b43b3714c65dfd32cd063c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyHeadersField » ContainerFetch Can'...
[ba6fa212f3e3857376b43b3714c65dfd32cd063c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyHitsField » ContainerFetch Can't g...
[ba6fa212f3e3857376b43b3714c65dfd32cd063c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyRequiredHitsField » ContainerFetch

chibenwa · 2018-11-12T08:18:31Z

test this please

rouazana · 2018-11-12T13:42:23Z

still

[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR] Errors: 
[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR]   SpamAssassinInvokerTest.learnAsHamShouldAllowToForgetSpam » ContainerLaunch Co...
[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR]   SpamAssassinInvokerTest.learnAsHamShouldReturnTrueWhenLearningWorks » ContainerLaunch
[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR]   SpamAssassinInvokerTest.learnAsSpamShouldReturnTrueWhenLearningWorks » ContainerLaunch
[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsHamWhenMessageAlreadyLearnedAsHam » ContainerLaunch
[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenKnownAsSpam » ContainerLaunch
[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenMessageAlreadyLearnedAsSpam » ContainerLaunch
[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyHeadersField » ContainerLaunch Con...
[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyHitsField » ContainerLaunch Contai...
[e244bf048151fffb286567264e4f6e7a256a899b] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyRequiredHitsField » ContainerLaunch

chibenwa · 2018-11-13T07:25:33Z

One minute is a little too low to build successfully a Dockerfile

rouazana · 2018-11-13T17:14:48Z

still

[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [INFO] Running org.apache.james.spamassassin.SpamAssassinResultTest
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.879 s - in org.apache.james.spamassassin.SpamAssassinResultTest
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [INFO] 
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [INFO] Results:
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [INFO] 
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR] Errors: 
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR]   SpamAssassinInvokerTest.learnAsHamShouldAllowToForgetSpam » ContainerLaunch Co...
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR]   SpamAssassinInvokerTest.learnAsHamShouldReturnTrueWhenLearningWorks » ContainerLaunch
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR]   SpamAssassinInvokerTest.learnAsSpamShouldReturnTrueWhenLearningWorks » ContainerLaunch
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsHamWhenMessageAlreadyLearnedAsHam » ContainerLaunch
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenKnownAsSpam » ContainerLaunch
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldMarkAsSpamWhenMessageAlreadyLearnedAsSpam » ContainerLaunch
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyHeadersField » ContainerLaunch Con...
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyHitsField » ContainerLaunch Contai...
[ba593118a7ae3798efb3757c7ee8b4c7d22cca6c] [ERROR]   SpamAssassinInvokerTest.scanMailShouldModifyRequiredHitsField » ContainerLaunch

test this please...

Fixes CVE-2017-15705, CVE-2016-1238, CVE-2018-11780 & CVE-2018-11781

…ocker

…assin docker

rouazana · 2018-11-14T08:23:46Z

...party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinWaitStrategy.java

@@ -52,7 +52,7 @@ public void waitUntilReady(WaitStrategyTarget waitStrategyTarget) {
                    return spamAssassinContainer
                        .execInContainer("spamassassin", "-V")
                        .getStdout()
-                        .contains("SpamAssassin version 3.4.1");
+                        .contains("SpamAssassin version 3.4.2");


third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinExtension.java

chibenwa · 2018-11-14T09:29:17Z

Merged

chibenwa added the enhancement label Oct 10, 2018

chibenwa added this to the polish_2018_10 milestone Oct 10, 2018

rouazana approved these changes Oct 10, 2018

View reviewed changes

trantienduchn approved these changes Oct 10, 2018

View reviewed changes

blackheaven approved these changes Oct 11, 2018

View reviewed changes

chibenwa force-pushed the JAMES-2558 branch from fb95fe1 to ba6fa21 Compare October 24, 2018 04:39

chibenwa force-pushed the JAMES-2558 branch from ba6fa21 to df96b27 Compare November 5, 2018 10:38

chibenwa added the security label Nov 5, 2018

chibenwa modified the milestones: polish_2018_10, Sprint 42 Nov 5, 2018

chibenwa force-pushed the JAMES-2558 branch from 2ed963d to e244bf0 Compare November 12, 2018 10:52

chibenwa added 3 commits November 14, 2018 11:36

JAMES-2558 Tests should rely on SpamAssassin 3.4.2

bc47a12

Fixes CVE-2017-15705, CVE-2016-1238, CVE-2018-11780 & CVE-2018-11781

JAMES-2588 increase timeout for starting SpamAssassin docker

0645a56

fixup! JAMES-2588 increase timeout for starting SpamAssassin docker

9e584b8

chibenwa force-pushed the JAMES-2558 branch from ba59311 to 9e584b8 Compare November 14, 2018 04:36

fixup! fixup! JAMES-2588 increase timeout for starting SpamAssassin d…

be8e726

…ocker

fixup! fixup! fixup! JAMES-2588 increase timeout for starting SpamAss…

8bcb5b1

…assin docker

trantienduchn approved these changes Nov 14, 2018

View reviewed changes

fixup! JAMES-2558 Tests should rely on SpamAssassin 3.4.2

9d150cd

aduprat approved these changes Nov 14, 2018

View reviewed changes

rouazana approved these changes Nov 14, 2018

View reviewed changes

mbaechler reviewed Nov 14, 2018

View reviewed changes

third-party/spamassassin/src/test/java/org/apache/james/spamassassin/SpamAssassinExtension.java Show resolved Hide resolved

chibenwa closed this Nov 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JAMES-2558 Tests should rely on SpamAssassin 3.4.2 #1793

JAMES-2558 Tests should rely on SpamAssassin 3.4.2 #1793

chibenwa commented Oct 10, 2018

chibenwa commented Oct 10, 2018

chibenwa commented Oct 10, 2018

chibenwa commented Oct 11, 2018

trantienduchn commented Oct 12, 2018

trantienduchn commented Oct 12, 2018

chibenwa commented Oct 12, 2018

chibenwa commented Oct 24, 2018

trantienduchn commented Oct 24, 2018

chibenwa commented Nov 5, 2018

trantienduchn commented Nov 5, 2018

chibenwa commented Nov 12, 2018

rouazana commented Nov 12, 2018

chibenwa commented Nov 13, 2018

rouazana commented Nov 13, 2018

rouazana Nov 14, 2018

chibenwa commented Nov 14, 2018

JAMES-2558 Tests should rely on SpamAssassin 3.4.2 #1793

JAMES-2558 Tests should rely on SpamAssassin 3.4.2 #1793

Conversation

chibenwa commented Oct 10, 2018

chibenwa commented Oct 10, 2018

chibenwa commented Oct 10, 2018

chibenwa commented Oct 11, 2018

trantienduchn commented Oct 12, 2018

trantienduchn commented Oct 12, 2018

chibenwa commented Oct 12, 2018

chibenwa commented Oct 24, 2018

trantienduchn commented Oct 24, 2018

chibenwa commented Nov 5, 2018

trantienduchn commented Nov 5, 2018

chibenwa commented Nov 12, 2018

rouazana commented Nov 12, 2018

chibenwa commented Nov 13, 2018

rouazana commented Nov 13, 2018

rouazana Nov 14, 2018

Choose a reason for hiding this comment

chibenwa commented Nov 14, 2018