JAMES-2886 extension-jars + jar with dependencies #2695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endency - Instantiate a dependency within the constructor - Instantiate a dependency within the service method
Arsnael
approved these changes
Sep 18, 2019
|
test this please |
trantienduchn
approved these changes
Sep 18, 2019
chibenwa
added a commit
to chibenwa/james-project
that referenced
this pull request
Sep 19, 2019
chibenwa
added
the
contribution
rouazana
approved these changes
Sep 20, 2019
| @@ -34,5 +34,6 @@ | |||
|
|
|||
| <modules> | |||
| <module>custom-mailets</module> | |||
| <module>dependency</module> | |||
There was a problem hiding this comment.
To ensure that we don't break compilation randomly?
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not clear to me, but things work smoothly with a jar-with-dependencies.
Hence the proposal to solve our kind user issue is to package apache-mailet-crypto in a jar with dependencies.