JAMES-2886 Custome Guice injections in James extensions jar #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
added
the
contribution
test this please |
chibenwa
added a commit
to chibenwa/james-project
that referenced
this pull request
Sep 20, 2019
… extension jar
Arsnael
approved these changes
Sep 20, 2019
chibenwa
force-pushed
the
guice-extensions
branch
from
ab9c89e
to
6ec0e30
Compare
|
Just rebased |
chibenwa
added a commit
to chibenwa/james-project
that referenced
this pull request
Sep 20, 2019
… extension jar
chibenwa
added a commit
to chibenwa/james-project
that referenced
this pull request
Sep 20, 2019
… extension jar
test this please. But interesting to dig? |
rouazana
reviewed
Sep 20, 2019
server/container/guice/guice-utils/src/test/java/org/apache/james/utils/ClassNameTest.java
Outdated
Show resolved
Hide resolved
...iner/guice/guice-utils/src/test/java/org/apache/james/utils/FullyQualifiedClassNameTest.java
Show resolved
Hide resolved
server/container/guice/guice-utils/src/test/java/org/apache/james/utils/PackageNameTest.java
Outdated
Show resolved
Hide resolved
server/container/guice/guice-utils/src/main/java/org/apache/james/utils/GuiceGenericLoader.java
Outdated
Show resolved
Hide resolved
Arsnael
reviewed
Sep 23, 2019
server/container/guice/guice-utils/src/test/java/org/apache/james/utils/PackageNameTest.java
Outdated
Show resolved
Hide resolved
|
test this please |
|
test this please |
rouazana
approved these changes
Sep 23, 2019
rouazana
approved these changes
Sep 23, 2019
chibenwa
added
waiting_merge
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did I work on this?
As a preparation for the ApacheCon, talk promoting James as a flexible and extensible email server, I intend to present the following use case:
(Then I will present other extensions (MailboxListener, ProtocolHandlers, PreDeletionHooks, etc...)
Why this work is different from the previous proposals?
Here it is important to notice, a child injector is used, and is specific to extensions (custom mailet, matchers, etc..).
Regular James entities are unaffected by these bindings that empower the user to write powerful extensions.
Furthermore, this enables to write extensions applying orthogonal architecture, and enables an easy packaging and distribution0
Final notes
I believe this is one of the missing building block for Guice adoption.
Remain work for this "ApacheCon" plan
Well, allow custom WebAdmin routes <3